[Denemo-devel] Problems with the window installer. Re: [bug #45956] Installer deletes system path.

[Richard Shann]

Jeremiah,
I think there is something we could try to improve the windows
installer.
In https://github.com/jjbenham/gub/blob/master/nsis/denemo.nsi

there is this function:

Function postinstall_denemo
        CopyFiles /silent "$INSTDIR\usr\share\fonts\truetype\denemo\Denemo.ttf" 
"$WINDIR\Fonts\Denemo.ttf"
        StrCpy $FONT_DIR "$WINDIR\Fonts"
        !insertmacro InstallTTFFont 
"${ROOT}\usr\share\fonts\truetype\denemo\Denemo.ttf"
        CopyFiles /silent "$INSTDIR\usr\share\fonts\truetype\denemo\feta.ttf" 
"$WINDIR\Fonts\feta.ttf"
        !insertmacro InstallTTFFont 
"${ROOT}\usr\share\fonts\truetype\denemo\feta.ttf"
        CopyFiles /silent 
"$INSTDIR\usr\share\fonts\truetype\denemo\emmentaler.ttf" 
"$WINDIR\Fonts\emmentaler.ttf"
        !insertmacro InstallTTFFont 
"${ROOT}\usr\share\fonts\truetype\denemo\emmentaler.ttf"
        ClearErrors
FunctionEnd

I think this may have stopped working with some versions of windows:
When I manually drag feta.ttf to the $WINDIR\Fonts\ directory windows
actually changes the name to feta25.2.ttf and the emmentaler.ttf is
renamed to Emmentaler-26.ttf

So it may be that replacing that version of postinstall_denemo with this
will work:

Function postinstall_denemo
        CopyFiles /silent "$INSTDIR\usr\share\fonts\truetype\denemo\Denemo.ttf" 
"$WINDIR\Fonts\Denemo.ttf"
        StrCpy $FONT_DIR "$WINDIR\Fonts"
        !insertmacro InstallTTFFont 
"${ROOT}\usr\share\fonts\truetype\denemo\Denemo.ttf"
        CopyFiles /silent "$INSTDIR\usr\share\fonts\truetype\denemo\feta.ttf" 
"$WINDIR\Fonts\feta25.2.ttf"
        !insertmacro InstallTTFFont 
"${ROOT}\usr\share\fonts\truetype\denemo\feta.ttf"
        CopyFiles /silent 
"$INSTDIR\usr\share\fonts\truetype\denemo\emmentaler.ttf" 
"$WINDIR\Fonts\Emmentaler-26.ttf"
        !insertmacro InstallTTFFont 
"${ROOT}\usr\share\fonts\truetype\denemo\emmentaler.ttf"
        ClearErrors
FunctionEnd


Though why there should be both the CopyFiles command and the
InstallTTFont procedure run I don't understand.

Could you try this out on a build of the mingw exe installer?

The other puzzle is why the installer seems to be adding to the system
path environment variable, the function to do that has been commented
out for some years, but I can't quite trace all the logic...

Richard

On Mon, 2015-09-14 at 09:32 +0000, Richard Shann wrote:
> Update of bug #45956 (project denemo):
> 
>                   Status:                    None => Need Info              
> 
>     _______________________________________________________
> 
> Follow-up Comment #1:
> 
> I have installed it on a windows Vista machine, the Denemo path appears
> appended to another path - in fact appended twice because, I presume of an
> earlier install. The irony is that Denemo does not use the path at all, I've
> deleted it from the path and Denemo continues to work fine.
> What did happen on this install was that the feta.ttf and emmentaler.ttf fonts
> were not intalled - I copied them to the C:\Windows\Fonts directory and all
> worked.
> Very bizarrely, on copying them to that directory, windows looked inside the
> font file, extracted the internal name of the font and re-named the files to
> be the actual name of the font.
> 
> What version of Windows did you have that experience - and are you quite sure
> that there was something in the path that got erased?
> Try altering the Denemo path that is there to say XXXDenemo and then
> re-installing. Does it append?
> 
>     _______________________________________________________
> 
> Reply to this item at:
> 
>   <http://savannah.gnu.org/bugs/?45956>
> 
> _______________________________________________
>   Message sent via/by Savannah
>   http://savannah.gnu.org/
>