[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] build: avoid compile warnings in factor.c on some system
|
From: |
Jim Meyering |
|
Subject: |
Re: [PATCH 2/3] build: avoid compile warnings in factor.c on some systems |
|
Date: |
Tue, 23 Oct 2012 14:41:23 +0200 |
Pádraig Brady wrote:
> On 10/23/2012 01:13 PM, Jim Meyering wrote:
>> Thanks.
>> I confirmed that this addresses the problem.
>>
>> Did you consider other ways of addressing it,
>> say without adding that cast? Imagine that
>> someone adds another addmod2 use in this code...
>> They will have to know to widen any argument that may
>> be narrower than uintmax_t.
>
> I agree it's not ideal,
> though I couldn't really come up with anything really clean,
> since it's a mixture of assembly and C.
>
> I'd already pushed before I saw this comment.
No problem.
- Re: more compile warnings with new factor, (continued)
- Re: more compile warnings with new factor, Pádraig Brady, 2012/10/23
- [PATCH 1/3] build: avoid build failure on some sparc systems, Pádraig Brady, 2012/10/23
- Re: [PATCH 1/3] build: avoid build failure on some sparc systems, Jim Meyering, 2012/10/23
- [PATCH 2/3] build: avoid compile warnings in factor.c on some systems, Pádraig Brady, 2012/10/23
- Re: [PATCH 2/3] build: avoid compile warnings in factor.c on some systems, Jim Meyering, 2012/10/23
- Re: [PATCH 2/3] build: avoid compile warnings in factor.c on some systems, Pádraig Brady, 2012/10/23
- Re: [PATCH 2/3] build: avoid compile warnings in factor.c on some systems,
Jim Meyering <=
- [PATCH 3/3] build: avoid warnings about unused variables and macros, Pádraig Brady, 2012/10/23
- Re: [PATCH 3/3] build: avoid warnings about unused variables and macros, Jim Meyering, 2012/10/23