coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] build: avoid warnings about unused variables and macros


From: Jim Meyering
Subject: Re: [PATCH 3/3] build: avoid warnings about unused variables and macros
Date: Tue, 23 Oct 2012 13:42:16 +0200

Pádraig Brady wrote:
> src/factor.c (__GMP_DECLSPEC): Move back from longlong.h
> to treat consistently with other stub macros.
> (__GMP_GNUC_PREREQ): Reference to avoid -Wunused-macros warning.
> (__GMP_DECLSPEC): Likewise.
> (ASSERT): Likewise.
> (__clz_tab): Likewise.
> (factor_using_division): Mark variable as unused.

Thanks for addressing these!

Really tiny nit, but s/Mark/Mark a/
I mention it only because as-is, it made me think
factor_using_division was the "variable", when in fact it is merely
the function that contains the affected declaration.

> (mulredc): Likewise.
> (mulredc2): Likewise.
> (divexact_21): Likewise.
...
> @@ -751,7 +759,7 @@ factor_using_division (uintmax_t *t1p, uintmax_t t1, 
> uintmax_t t0,
>      {
>        for (;;)
>          {
> -          uintmax_t q1, q0, hi, lo;
> +          uintmax_t q1, q0, hi, lo ATTRIBUTE_UNUSED;



reply via email to

[Prev in Thread] Current Thread [Next in Thread]