|
From: | Pádraig Brady |
Subject: | Re: [PATCH 2/3] build: avoid compile warnings in factor.c on some systems |
Date: | Tue, 23 Oct 2012 13:34:33 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 |
On 10/23/2012 01:13 PM, Jim Meyering wrote:
Thanks. I confirmed that this addresses the problem. Did you consider other ways of addressing it, say without adding that cast? Imagine that someone adds another addmod2 use in this code... They will have to know to widen any argument that may be narrower than uintmax_t.
I agree it's not ideal, though I couldn't really come up with anything really clean, since it's a mixture of assembly and C. I'd already pushed before I saw this comment. thanks, Pádraig.
[Prev in Thread] | Current Thread | [Next in Thread] |