Re: [PATCH] Recognize aarch64_ilp32

[Andreas Schwab]

On Dez 05 2016, Jan Engelhardt <address@hidden> wrote:

> On Monday 2016-12-05 14:03, Ben Elliston wrote:
>>On Mon, Dec 05, 2016 at 01:37:21PM +0100, Andreas Schwab wrote:
>>
>>> +    aarch64:Linux:*:* | aarch64_be:Linux:*:*)
>>> +   eval $set_cc_for_build
>>> +   if echo __ILP32__ | $CC_FOR_BUILD -E - 2>/dev/null \
>>> +       | grep -q __ILP32__
>>> +   then
>>> +       :
>>> +   else
>>> +       UNAME_MACHINE=${UNAME_MACHINE}_ilp32
>>> +   fi
>>
>>Please don't use set_cc_for_build. From config.guess:
>>
>># CC_FOR_BUILD -- compiler used by this script. Note that the use of a
>># compiler to aid in system detection is discouraged as it requires
>># temporary files to be created and, as you can see below, it is a
>># headache to deal with in a portable fashion.
>>
>>Please find another way to get the ilp32 status.  I'm not accepting
>>new uses of set_cc_for_build, because it is an abomination.
>
> Furthermore, ILP32 modes are not supposed to be expressed in the platform
> tuple. x32 configurations, so far, are simply invoked as
>  ./configure --host=x86_64-linux-gnu CFLAGS=-m32 LDFLAGS=-m32
> because that's what it is.

That doesn't work.  Something must distinguish the ABI.

Andreas.

-- 
Andreas Schwab, SUSE Labs, address@hidden
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."