Re: [PATCH] Recognize aarch64_ilp32

[Ben Elliston]

On Mon, Dec 05, 2016 at 01:37:21PM +0100, Andreas Schwab wrote:

> +    aarch64:Linux:*:* | aarch64_be:Linux:*:*)
> +     eval $set_cc_for_build
> +     if echo __ILP32__ | $CC_FOR_BUILD -E - 2>/dev/null \
> +         | grep -q __ILP32__
> +     then
> +         :
> +     else
> +         UNAME_MACHINE=${UNAME_MACHINE}_ilp32
> +     fi

Please don't use set_cc_for_build. From config.guess:

# CC_FOR_BUILD -- compiler used by this script. Note that the use of a
# compiler to aid in system detection is discouraged as it requires
# temporary files to be created and, as you can see below, it is a
# headache to deal with in a portable fashion.

Please find another way to get the ilp32 status.  I'm not accepting
new uses of set_cc_for_build, because it is an abomination.

Cheers,
Ben

signature.asc
Description: Digital signature