Re: [Bug-wget] Wget 1.12 v. VMS

[Micah Cowan]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Steven M. Schweda wrote:
> From: Micah Cowan
> 
>> Can you provide me with appropriate ChangeLog entries for these changes?
>> ...You can edit the appropriate ChangeLog files directly, and send me
>> the diff.
> 
>    Something like these?

<snip>

Yes, thanks very much.

Could you also add one to cover whatever new work was done to src/vms.c?

>> You can leave out the print_version changes from main.c, as I haven't
>> included those changes; [...]
> 
>    Did you fix the old/bad line-wrap code so that it makes more sense? 
> The main reason it even appeared to work correctly was this off-by-one
> error:
>           printf ("%s ", compiled_features[i]);
>           line_length -= strlen (compiled_features[i]) + 2;
> 
> "2"?  Why "2"?  You might be (at least slightly) better off keeping the
> parts of my code which put out the old array.  With or without the
> TABULATION thing, it should be able to count the characters accurately. 
> (I made the mistake of testing with some long option names.  The
> old-code results were not pretty.)

I'll investigate this. Thanks for pointing it out.

- --
Micah J. Cowan
Programmer, musician, typesetting enthusiast, gamer.
Maintainer of GNU Wget and GNU Teseq
http://micah.cowan.name/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkrPsRAACgkQ7M8hyUobTrG0hACeLz7fR6ln76fd31eYEU7h9N75
D98AnjPD/VBVcnXzJdYmJy8tLqiuPMCu
=Cji6
-----END PGP SIGNATURE-----