Re: [Bug-wget] Wget 1.12 v. VMS

[Steven M. Schweda]

From: Micah Cowan

> Can you provide me with appropriate ChangeLog entries for these changes?
> ...You can edit the appropriate ChangeLog files directly, and send me
> the diff.

   Something like these?

--- ChangeLog._orig     2009-09-25 17:17:48 -0500
+++ ChangeLog   2009-10-09 15:48:07 -0500
@@ -1,3 +1,36 @@
+2009-10-09  Steven Schweda  <address@hidden>
+
+       * New VMS MMS/MMK builders, to accommodate the new source tree
+       structure:
+       lib/DESCRIP_DEPS.MMS            Dependencies (lib)
+       lib/DESCRIP_MODS.MMS            Modules (lib)
+       lib/DESCRIP_SRC.MMS             Main (lib)
+       md5/DESCRIP_DEPS.MMS            Dependencies (md5)
+       md5/DESCRIP_MODS.MMS            Modules (md5)
+       md5/DESCRIP_SRC.MMS             Main (md5)
+       src/DESCRIP_DEPS.MMS            Dependencies (src)
+       src/DESCRIP_MODS.MMS            Modules (src)
+       src/DESCRIP_SRC.MMS             Main (src)
+       vms/DESCRIP.MMS                 Main (global)
+       vms/DESCRIP_MKDEPS.MMS          Dependency generator
+       vms/DESCRIP_SRC.MMS             Main (main)
+       vms/DESCRIP_SRC_CMN.MMS         Main (common)
+       vms/DESCRIP_SRC_FLAGS.MMS       Compiler and linker flags
+       vms/COLLECT_DEPS.COM            Dependency processor
+       vms/CONFIG_EXTRACT.COM          Extract AC_INIT from configure.ac
+       vms/WGET_MULTINET.OPT           Link options for (old) MultiNet
+       vms/WGET_SSL_HP.OPT             Link options for HP SSL
+       vms/WGET_SSL_O.OPT              Link options for OpenSSL
+
+       * Other VMS-specific files:
+       vms/alloca.h                    Dummy alloca.h.
+       vms/config.h_vms                Manually crafted config.h
+       vms/stdint.h                    Dummy stdint.h
+       vms/vms.h                       Declarations, prototypes for vms.c
+       vms/vms_ip.h                    Helper for netdb.h
+       vms/VMS_NOTES.TXT               Instructions, notes
+       vms/WGET.HLP                    Basic VMS HELP
+
 2009-09-24  Micah Cowan  <address@hidden>
 
        * vms/vms.c: Moved to src/src.c.


--- src/ChangeLog._orig 2009-09-25 17:17:48 -0500
+++ src/ChangeLog       2009-10-09 15:16:51 -0500
@@ -1,3 +1,8 @@
+2009-10-09  Steven Schweda  <address@hidden>
+
+       * utils.c: Added characters " : \ | to the list of normal
+       caret-escaped (ODS5) characters in the char_prop[] table.
+
 2009-09-24  Micah Cowan  <address@hidden>
 
        * vms.c: Moved from vms/vms.c.


   It might make some sense to create a vms/ChangeLog.  Lacking one, I
just threw things into ./ChangeLog.


> You can leave out the print_version changes from main.c, as I haven't
> included those changes; [...]

   Did you fix the old/bad line-wrap code so that it makes more sense? 
The main reason it even appeared to work correctly was this off-by-one
error:
          printf ("%s ", compiled_features[i]);
          line_length -= strlen (compiled_features[i]) + 2;

"2"?  Why "2"?  You might be (at least slightly) better off keeping the
parts of my code which put out the old array.  With or without the
TABULATION thing, it should be able to count the characters accurately. 
(I made the mistake of testing with some long option names.  The
old-code results were not pretty.)


> And of course I'm completely retarded here [...]

   Oh, not completely.  Everything's complicated.  I should already be
setting SIZEOF_OFF_T correctly (vms/config.h_vms), so a (simple) test
based on that should go with no extra effort by me.  (If I'd been even
slightly alert, I might have noticed that that one already existed. 
Sigh.)

> [...] Thanks!

   Oh, no.  Thank _you_.  As always, wake me if there's more I should
do.

   SMS.