Re: [bug-myserver] toward MyServer 0.9

[Francesco Pipita]

I premise that I am not experienced like Daniele and Giuseppe in
planning things, I consider myself more like a "Software Mason" than a
Software Engineer :)

> Daniele Perrone <address@hidden> writes:
> 
> I don't think refactoring is a good thing to do between RC1 and RC2, because 
> of
> the test coverage is quite poor, so it's high probable that with refactoring 
> we
> introduce new bugs, so i thing we can clean the code before the RC1, and
> increase  test coverage and fix new bugs between  RC1 and final release.

Just because of the test coverage is still poor, and one of the main
targets, before any release, is to verify the code correctness,
refactoring may be a good way to enforce the writing of new and clearer
tests, because after refactoring, the code should be cleaner and
splitted in smaller methods easier to test, so IMO, it can be done
during any step of the development process.

In addition, for already existing tests, refactoring shouldn't change
any behavior, so if tests passed before, they also will later. If
some new bug is introduced and we can't discover it, it is only because
previous tests we wrote, weren't good enough.

Finally, my idea, was referred just to the recenlty added and well known
code (the one written from zero), not even to all the MyServer code, of
course. That may really break everything :)

> Giuseppe Scrivano <address@hidden> writes:
> -
> I think refactoring must be done before RC1, do substantial changes
> between RC's is not a good idea as we can introduce new bugs instead of
> fixing old ones.

My concept of refactoring is maybe wrong. My idea of it, is that it
should just change the code look, not its behavior. So, if its behavior
was correct before, it will be also later (and tests can prove its
correctness). Anyway, this discussion is maybe beyond of the scope of
the Giuseppe's initial message :)

The most important thing is that we agree on the three foundamental
points focused by Giuseppe in his first message.
Best regards,

   Francesco