Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.

[Erik Auerswald]

Hello Simon,

On Fri, Jul 08, 2022 at 08:55:18AM +0200, Erik Auerswald wrote:
> On Fri, Jul 08, 2022 at 12:58:37AM +0200, Simon Josefsson wrote:
> 
> > Thanks for preparing these, I should have read through all posts
> > before started working on them separately... so this patch no longer
> > applies as is.  Would you like to re-review these, to see if anything
> > more is still needed after I applied some changes?  Maybe it is just
> > the NEWS entries.
> 
> Thanks for applying my patches!
> 
> I'll try to look into this over the weekend, but I cannot promise
> anything.  But this patch series should just address the same issues
> as the patches I sent before, perhaps with some smaller differences.
> It's been some time and I do not remember all the details.

The code looks good.  As intended the two genget() changes are not
included, everything else is.  The NEWS entries look good, too.

Thanks,
Erik
-- 
It's impossible to learn very much by simply sitting in a lecture,
or even by simply doing problems that are assigned.
                        -- Richard P. Feynman