Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.

[Simon Josefsson]

Erik Auerswald <auerswal@unix-ag.uni-kl.de> writes:

> Hello Simon,
>
> On Fri, Jul 08, 2022 at 08:55:18AM +0200, Erik Auerswald wrote:
>> On Fri, Jul 08, 2022 at 12:58:37AM +0200, Simon Josefsson wrote:
>> 
>> > Thanks for preparing these, I should have read through all posts
>> > before started working on them separately... so this patch no longer
>> > applies as is.  Would you like to re-review these, to see if anything
>> > more is still needed after I applied some changes?  Maybe it is just
>> > the NEWS entries.
>> 
>> Thanks for applying my patches!
>> 
>> I'll try to look into this over the weekend, but I cannot promise
>> anything.  But this patch series should just address the same issues
>> as the patches I sent before, perhaps with some smaller differences.
>> It's been some time and I do not remember all the details.
>
> The code looks good.  As intended the two genget() changes are not
> included, everything else is.  The NEWS entries look good, too.

Thank you!  I don't care strongly about the genget patches, I mostly
have a general concern that we should minimize changes with no
externally testable difference.  OTOH, the NetBSD folks patched the
telnet bugs in a different way than we did, and I'm not sure how to
handle that...  we could adopt their solution, or stick with ours.

https://cvsweb.netbsd.org/bsdweb.cgi/src/usr.bin/telnet/commands.c.diff?r1=1.79&r2=1.80&only_with_tag=MAIN

Let's see if the FreeBSD and OpenBSD folks apply it or come with
something different...

Maybe the goal of harmonizing the various implementations is just a pipe
dream...

/Simon

signature.asc
Description: PGP signature