Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.

[Erik Auerswald]

Hello Simon,

On Fri, Jul 08, 2022 at 11:49:57AM +0200, Simon Josefsson wrote:
> Erik Auerswald <auerswal@unix-ag.uni-kl.de> writes:
> 
> > I want to look at your new tests, perhaps I can learn how to add some
> > tests to verify the genget() functionality.
> 
> The test suite today is rather limited, as you probably have noticed,
> but going forward it would really help if we created a self-check that
> triggers a bug we want to solve, and then confirm that it actually
> fails during build, and then succeeds after patching the bug.
> 
> You may want to look at NixOS or GitLab CI/CD for build failures:
> https://hydra.nixos.org/jobset/gnu/inetutils-master
> https://gitlab.com/jas/inetutils/-/pipelines
> The GitLab recipe is here:
> https://gitlab.com/jas/inetutils-cicd/-/blob/master/inetutils.yml

The Debian 11 build fails because it attempts to create a release with
a bogus version number.  The error is:

    ...
      GEN      release-prep
    announce-gen: ./NEWS: no news item found for '42.4711'
    make[3]: *** [maint.mk:1422: announcement] Error 25
    make[2]: *** [maint.mk:1542: release-prep] Error 2
    make[2]: Leaving directory '/builds/jas/inetutils'
    make[1]: *** [maint.mk:1526: stable] Error 2
    make[1]: Leaving directory '/builds/jas/inetutils'
    make: *** [maint.mk:1534: release] Error 2

see https://gitlab.com/jas/inetutils-cicd/-/blob/master/inetutils.yml#L101
and https://gitlab.com/jas/inetutils-cicd/-/blob/master/inetutils.yml#L102

> I'm not that familiar with NixOS but noticed now that builds fail.

The NixOS build fails because of too old Automake:

    lib/Makefile.am:110: require Automake 1.14, but have 1.11.6
    ...
    autoreconf: automake failed with exit status: 1
    ./bootstrap: autoreconf failed

see https://hydra.nixos.org/build/183833122/nixlog/1/tail

HTH,
Erik