[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug-inetutils] Re: ftp: command processing
From: |
Simon Josefsson |
Subject: |
[bug-inetutils] Re: ftp: command processing |
Date: |
Tue, 28 Aug 2007 16:09:43 +0200 |
User-agent: |
Gnus/5.110007 (No Gnus v0.7) Emacs/22.1 (gnu/linux) |
"Debarshi 'Rishi' Ray" <address@hidden> writes:
>> Just remove all
>> readline stuff from configure.ac, remove the non-readline case in
>> ftp/main.c, and add the gnulib readline module, and you should be set.
>
> We still need to check for libreadline in configure.ac, since gnulib
> does not provide the add_history function, which is used by Inetutils.
Gnulib checks for libreadline, so I don't think that check needs to be
duplicated.
> Even if we use the readline module from gnulib, we have to envelop the
> add_history calls with #if HAVE_LIBREADLINE...#endif pairs.
Yes, or perhaps cleaner: add a AC_CHECK_FUNC(add_history) to
configure.ac, and make sure the test code links to any libreadline found
by gnulib. Then wrap the calls to add_history around #if
HAVE_ADD_HISTORY.
Another option would be to add the entire libreadline to the gnulib
module, so that it really does provide a add_history replacement as
well. But the libreadline code was rather ugly last time I checked, so
it may be difficult.
> By the way I have made the necessary changes to the patch, and will be
> sending it over after a bit of testing.
Great!
/Simon
- [bug-inetutils] ftp: command processing, Debarshi 'Rishi' Ray, 2007/08/08
- [bug-inetutils] Re: ftp: command processing, Debarshi 'Rishi' Ray, 2007/08/11
- [bug-inetutils] Re: ftp: command processing, Debarshi 'Rishi' Ray, 2007/08/15
- [bug-inetutils] Re: ftp: command processing, Simon Josefsson, 2007/08/15
- [bug-inetutils] Re: ftp: command processing, Debarshi 'Rishi' Ray, 2007/08/15
- [bug-inetutils] Re: ftp: command processing, Simon Josefsson, 2007/08/15
- [bug-inetutils] Re: ftp: command processing, Debarshi 'Rishi' Ray, 2007/08/15
- [bug-inetutils] Re: ftp: command processing, Simon Josefsson, 2007/08/15
- [bug-inetutils] Re: ftp: command processing, Debarshi 'Rishi' Ray, 2007/08/15
- [bug-inetutils] Re: ftp: command processing, Debarshi 'Rishi' Ray, 2007/08/28
- [bug-inetutils] Re: ftp: command processing,
Simon Josefsson <=
- [bug-inetutils] Re: ftp: command processing, Debarshi 'Rishi' Ray, 2007/08/28
- Re: [bug-inetutils] Re: ftp: command processing, Alfred M. Szmidt, 2007/08/29
- [bug-inetutils] Re: ftp: command processing, Simon Josefsson, 2007/08/29
- [bug-inetutils] Re: ftp: command processing, Alfred M. Szmidt, 2007/08/30
- Re: [bug-inetutils] Re: ftp: command processing, Debarshi 'Rishi' Ray, 2007/08/30
- Re: [bug-inetutils] Re: ftp: command processing, Alfred M. Szmidt, 2007/08/31
- Re: [bug-inetutils] Re: ftp: command processing, Debarshi 'Rishi' Ray, 2007/08/31
- Re: [bug-inetutils] Re: ftp: command processing, Alfred M. Szmidt, 2007/08/31
- [bug-inetutils] Re: ftp: command processing, Simon Josefsson, 2007/08/31
- Re: [bug-inetutils] Re: ftp: command processing, Alfred M. Szmidt, 2007/08/15