Re: OmniOS CI failure for test-fnmatch-5.sh

[Collin Funk]

Hi Bruno,

On 5/21/24 2:13 PM, Bruno Haible wrote:
>> I pushed the attached patch adding the #if defined __illumos__.
>
> It apparently has the desired effect. So, let me do the same thing with
> the test-trim3.sh test, that fails like this:
> 
> FAIL: test-trim3.sh
> ===================
> 
> ../../gltests/test-trim.c:150: assertion 'strcmp (result, "\241\244foo") == 
> 0' failed

Looking into the __illumos__ macro it appears to be relatively new.
The original bug report is 3 years old [1]. The change was added to
OmniOS in version r15038s in 2021 [2].

I think it is still worth using since your CI should be using a later
version. If someone is using an older version perhaps they will see
the __illumos__ check and see it was expected to fail.

If someone reports a bug then we will know what the issue is. I think
using those macros as "documentation" is important. We can tell a test
passes on OpenSolaris derivatives but not Oracle Solaris.

I'm not sure if you would rather use something more common like __sun
though.

Collin

[1] https://www.illumos.org/issues/13726
[2] https://omnios.org/article/release-r38s