Re: OmniOS CI failure for test-fnmatch-5.sh

[Collin Funk]

On 5/21/24 1:39 AM, Bruno Haible wrote:
>> I was taking a look at the CI stuff you wrote. Nice work, it seems
>> really helpful.
> 
> Thanks for helping! The goal here being to get all FAILs either fixed
> or declared as XFAIL, this really helps.

Sounds like a good plan. I can help with fixing the free systems but
the proprietary ones might need more XFAIL treatment. :)

I feel like MacOS will probably be problematic. I can see that it
already caused you a lot of trouble [1].

> Since this failure is not seen on Solaris 11.4, the 'defined __illumos__'
> is correct.

Yes, I saw that the regular Solaris 11 CI passed. I figured it was
best to leave the test running there. If it ever fails in the future
we can see what version causes problems.

>> I think it might be a bug in OmniOS's handling of GB 18030 but I am
>> unsure.
> 
> On these systems, every locale has its own character classifications
> tables. It can happen that they treat U+00D7 MULTIPLICATION SIGN
> as a punctuation character in the UTF-8 locale but not in the GB18030
> locale. (Glibc avoids this by computing the character classifications
> tables for all encodings from a single source.)
> 
>> Maybe I am missing a good English specification or lack the
>> ability to learn Mandarin...
> 
> You don't need to understand Mandarin in order to work GB18030.
> GB18030 is an ASCII-based encoding of all Unicode, like UTF-8, just with
> a different mapping table.

Ah, okay. Thanks for the explanations. I think I understand what is
going on now. I had a look at GNU Iconv and the charts on Wikipedia
too. No more need to learn Mandarin.

I pushed the attached patch adding the #if defined __illumos__.

Collin

[1] https://lists.gnu.org/archive/html/bug-gnulib/2024-05/msg00330.html

0001-fnmatch-tests-Avoid-test-failure-on-OmniOS.patch
Description: Text Data