automake
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: rhel8 test failure confirmation?


From: Jacob Bachmeyer
Subject: Re: rhel8 test failure confirmation?
Date: Tue, 05 Dec 2023 22:24:11 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.22) Gecko/20090807 MultiZilla/1.8.3.4e SeaMonkey/1.1.17 Mnenhy/0.7.6.0

Zack Weinberg wrote:
On Mon, Dec 4, 2023, at 7:14 PM, Jacob Bachmeyer wrote:
Zack Weinberg wrote:
[snip everything addressed in the other thread]
Yes, there was a bit of confusion here; not only is the FileUtils
module synchronized between autom4te and automake

Thanks for reminding me that I need to make sure all those files are
actually in sync before I cut the final 2.72 release.

      require Time::HiRes;
      import Time::HiRes qw(stat);
I believe that the import is not actually necessary

The previous line is a "require", not a "use", so I believe it _is_
necessary.  Have I misunderstood?

... should do no harm as long as any use of stat in the code
is prepared to handle floating-point timestamps.

There's only one use, in 'sub mtime', and that's the place
where we actively want the floating-point timestamps.

Yes, before seeing your actual patch, I had the mistaken impression that this code was in autom4te itself, not the FileUtils module. The import is needed in the FileUtils module, so the patch is correct.


-- Jacob




reply via email to

[Prev in Thread] Current Thread [Next in Thread]