automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: PATCH: silence Shellcheck warning


From: Mike Frysinger
Subject: Re: PATCH: silence Shellcheck warning
Date: Tue, 18 Jan 2022 21:50:04 -0500

On 18 Jan 2022 21:25, Ben Elliston wrote:
> On Tue, Jan 18, 2022 at 04:18:52AM -0500, Mike Frysinger wrote:
> > that said, automake targets lower than POSIX, so i agree that we
> > should leave it be for automake specifically.  feel like posting a
> > patch to suppress this particular check in lib/missing instead ?
> 
> If it's welcome, sure. Some people are opposed to littering pragmas
> through source files to disable linters that they think do more harm
> than good.

tl;dr: using shellcheck directives in automate shell scripts sgtm.

shell does not lend itself to being written correctly.  shellcheck has
proven its worth to me multiple times over, especially because i can stop
having to point out the same mistakes to people over & over that it easily
finds.  we've integrated into CrOS & internally at Google and people love
it.  at least, people still (rightly) hate shell, but not much to be done
about that other than use a better language :P.
-mike

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]