Re: PATCH: silence Shellcheck warning

[Mike Frysinger]

On 22 Jul 2018 14:41, Nick Bowler wrote:
> On 7/21/18, Ben Elliston <bje@air.net.au> wrote:
> > This patch silences a warning from Shellcheck about using old-style
> > `...` command substitutions.
> [...]
> > commit 4d35c7aae97234bf055519075ef03cd4090a1dfc
> > Author: Ben Elliston <bje@air.net.au>
> > Date:   Sun Jul 22 08:22:44 2018 +1000
> >
> >     * missing: Use $(..) command substitution syntax.
> 
> Several shells do not support $(...) substitutions so portable scripts
> like 'missing' must always use backticks.  I would suggest that this
> linter warning is spurious if not outright counterproductive.

Shellcheck is doing the right thing.  it targets POSIX, not ancient
shells that the vast majority people should never waste their time on.

that said, automake targets lower than POSIX, so i agree that we should
leave it be for automake specifically.  feel like posting a patch to
suppress this particular check in lib/missing instead ?
-mike

signature.asc
Description: PGP signature