[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: fix py-compile-basedir.sh: add missing test call
|
From: |
Mike Frysinger |
|
Subject: |
Re: [PATCH] tests: fix py-compile-basedir.sh: add missing test call |
|
Date: |
Tue, 18 Jan 2022 21:30:24 -0500 |
On 18 Jan 2022 11:29, Jim Meyering wrote:
> On Tue, Jan 18, 2022 at 10:29 AM Mike Frysinger wrote:
> > On 18 Jan 2022 09:48, Jim Meyering wrote:
> ...
> > > But IMHO that's too much duplication/syntax.
> > > How about this instead?
> > >
> > > case $(echo "$files" | wc -l) in 4|6) ;; *) false;; esac
> >
> > looks reasonable for POSIX shell. not a fan of the one-line, but that style
> > seems to be SOP for test code, so i won't whine too loudly :p.
> >
> > i assume you'll take care of writing the actual patch at this point since it
> > was your idea ? :)
>
> Sure. How about this?
lgtm, thanks
-mike
signature.asc
Description: PGP signature