[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Handle odd winepath failures.
From: |
Peter Rosin |
Subject: |
Re: [PATCH] Handle odd winepath failures. |
Date: |
Tue, 31 Aug 2010 21:36:15 +0200 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.8) Gecko/20100802 Thunderbird/3.1.2 |
Den 2010-08-31 18:57 skrev Ralf Wildenhues:
> Hi Peter,
>
> * Peter Rosin wrote on Tue, Aug 31, 2010 at 06:47:24PM CEST:
>> Subject: [PATCH] Handle odd winepath failures.
>>
>> * lib/ar-lib (func_file_conv): winepath can exit with zero exit
>> status but empty result, and can return a basically unconverted
>> path, but prefixed with \\?\unix. Treat both of these as failure
>> and retain the original file name.
>> * lib/compile (func_file_conv): Likewise.
>> Suggested by Ralf Wildenhues after reports of similar problems
>> elsewhere from Charles Wilson and Roumen Petrov.
>
> OK for msvc if you update $scriptversion in both scripts and add a test
> case. Ideally two, one that is effective only on systems with wine
> installed and ensures that the output file name is not empty, the other
> one can fake, extending ar-lib.test.
That will have to wait then, because I can't test with real Wine easily
ATM...
Cheers,
Peter