automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Handle odd winepath failures.


From: Ralf Wildenhues
Subject: Re: [PATCH] Handle odd winepath failures.
Date: Tue, 31 Aug 2010 18:57:17 +0200
User-agent: Mutt/1.5.20 (2010-04-22)

Hi Peter,

* Peter Rosin wrote on Tue, Aug 31, 2010 at 06:47:24PM CEST:
> Subject: [PATCH] Handle odd winepath failures.
> 
> * lib/ar-lib (func_file_conv): winepath can exit with zero exit
> status but empty result, and can return a basically unconverted
> path, but prefixed with \\?\unix. Treat both of these as failure
> and retain the original file name.
> * lib/compile (func_file_conv): Likewise.
> Suggested by Ralf Wildenhues after reports of similar problems
> elsewhere from Charles Wilson and Roumen Petrov.

OK for msvc if you update $scriptversion in both scripts and add a test
case.  Ideally two, one that is effective only on systems with wine
installed and ensures that the output file name is not empty, the other
one can fake, extending ar-lib.test.

Thanks,
Ralf

> --- a/lib/ar-lib
> +++ b/lib/ar-lib
> @@ -70,7 +70,11 @@ func_file_conv ()
>         file=`cygpath -m "$file" || echo "$file"`
>         ;;
>       wine)
> -       file=`winepath -w "$file" || echo "$file"`
> +       wfile=`winepath -w "$file" 2>/dev/null || echo "$file"`
> +       case $wfile in
> +         '\\?\unix'* | '') ;;





reply via email to

[Prev in Thread] Current Thread [Next in Thread]