automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Do file name conversion for object files in the compile wrap


From: Peter Rosin
Subject: Re: [PATCH] Do file name conversion for object files in the compile wrapper.
Date: Tue, 31 Aug 2010 22:07:34 +0200
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.8) Gecko/20100802 Thunderbird/3.1.2

Hi Ralf!

Den 2010-08-31 19:02 skrev Ralf Wildenhues:
> * Peter Rosin wrote on Tue, Aug 31, 2010 at 06:59:25PM CEST:
>> When the compile wrapper is used to link, it needs to also
>> transform /absolute/object/files.obj to win32 format for
>> easy consumption by MSVC.
>>
>> Ok for the msvc branch?
> 
> Yes, bumping scriptversion and extending the best-fitting test, I'm
> guessing tests/compile4.test?  Or you can always add a new one.

Pushing and merging into master as attached.

The test fails w/o the compile script changes and passes with them.

Thanks for the review, and for all other reviews I forgot to thank
you for!

Cheers,
Peter

Attachment: 0001-Do-file-name-conversion-for-object-files-in-the-comp.patch.txt
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]