automake-ng
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Automake-NG] [PATCH 5/6] [ng] $(am__newline): will not be stripped


From: Dave Hart
Subject: Re: [Automake-NG] [PATCH 5/6] [ng] $(am__newline): will not be stripped unexpectedly
Date: Mon, 9 Jul 2012 13:32:30 +0000

On Mon, Jul 9, 2012 at 13:28 UTC, Stefano Lattarini wrote:
>>> +# A literlan newline character, that does not get stripped if used
>>
>> s/literlan/literal/ and also the comma should be removed.
>>
> Fixed.  I've also fixed another typo I've spotted while fixing the one
> you reported:

Nice catch.

>   diff --git a/lib/am/header-vars.am b/lib/am/header-vars.am
>   index 49b0ddb..b993d8c 100644
>   --- a/lib/am/header-vars.am
>   +++ b/lib/am/header-vars.am
>   @@ -50,7 +50,7 @@ am__dquote := "
>    am__squote := '
>    # "` # Fix font-lock.
>
>   -# A literlan newline character, that does not get stripped if used
>   +# A literala newline character, that does not get stripped if used

Third time's the charm?  s/literala/literal/

>    # at the end of the expansion of another macro.
>    define am__newline
>
>   @@ -266,7 +266,7 @@ am__strip_suffixes = $(strip \
>    ## FIXME: length limits, or at least on a system-by-system basis, might
>    ## FIXME: be better.  But don't make it too big, or our implementation
>    ## FIXME: will likely suffer in performance and memory consumption.
>   -# And in the Information Age, we somehow managed to revert an abacus-like
>   +# And in the Information Age, we somehow managed to revert to abacus-like

Agreed.

Cheers,
Dave Hart



reply via email to

[Prev in Thread] Current Thread [Next in Thread]