Re: [Automake-NG] [PATCH 5/6] [ng] $(am__newline): will not be stripped unexpectedly

[Stefano Lattarini]

On 07/08/2012 02:03 AM, Dave Hart wrote:
> On Sat, Jul 7, 2012 at 20:40 UTC, Stefano Lattarini wrote:
>> Not even if placed at the end of another macro's expansion.
>>
>> * lib/am/header-vars.am (am__newline): Improve definition, and
>> update comments.
>> * t/internals.sh: Update: some previously xfailing checks are
>> now passing.
>>
>> Signed-off-by: Stefano Lattarini <address@hidden>
>> ---
>>  lib/am/header-vars.am |    4 +++-
>>  t/internals.tap       |    4 ++--
>>  2 files changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/lib/am/header-vars.am b/lib/am/header-vars.am
>> index d7afe6f..49b0ddb 100644
>> --- a/lib/am/header-vars.am
>> +++ b/lib/am/header-vars.am
>> @@ -50,9 +50,11 @@ am__dquote := "
>>  am__squote := '
>>  # "` # Fix font-lock.
>>
>> +# A literlan newline character, that does not get stripped if used
> 
> s/literlan/literal/ and also the comma should be removed.
>
Fixed.  I've also fixed another typo I've spotted while fixing the one
you reported:

  diff --git a/lib/am/header-vars.am b/lib/am/header-vars.am
  index 49b0ddb..b993d8c 100644
  --- a/lib/am/header-vars.am
  +++ b/lib/am/header-vars.am
  @@ -50,7 +50,7 @@ am__dquote := "
   am__squote := '
   # "` # Fix font-lock.

  -# A literlan newline character, that does not get stripped if used
  +# A literala newline character, that does not get stripped if used
   # at the end of the expansion of another macro.
   define am__newline

  @@ -266,7 +266,7 @@ am__strip_suffixes = $(strip \
   ## FIXME: length limits, or at least on a system-by-system basis, might
   ## FIXME: be better.  But don't make it too big, or our implementation
   ## FIXME: will likely suffer in performance and memory consumption.
  -# And in the Information Age, we somehow managed to revert an abacus-like
  +# And in the Information Age, we somehow managed to revert to abacus-like
   # counting.  Yay for us :-)
   am.max-cmdline-args := xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

Thanks,
  Stefano