Re: autotest fails when pwd is testgroup directory

[Ralf Wildenhues]

Hi Eric,

* Eric Blake wrote on Fri, Apr 07, 2006 at 05:57:06AM CEST:
> According to Noah Misch on 4/5/2006 8:10 AM:
> > 
> >> Also, should we document AS_ERROR and friends in autoconf.texi?
> > 
> > I don't have an opinion on this.
> 
> Ralf mentioned AC_MSG_ERROR, but that has different semantics (exit
> autoconf, not configure).

This is simply not true (I guess you were thinking of AC_FATAL),
but you've already seen that as well.

> So, (in a separate patch), here is a first cut
> at documenting another portion of m4sh.

I have several issues with that, and as such advise to postpone this,
for now.  We can have detailed discussions about this when no release
is before us.

> >> Also, AS_MKDIR_P is not threadsafe if mkdir -p is not supported, is
> >> that a problem?
> > 
> > This does not matter for Autoconf.
> 
> I improved my documentation attempt to try to capture this idea.

I disagree here, respectfully.  Paul has suggested more than once that
parallelism of tests could be a useful feature of a future Autoconf
version.  However that idea may turn out: let's not give guarantees
about non-parallelism unless we have to.

> >>    * doc/autoconf.texi (Programming in M4sh): Document that
> >>    AS_MKDIR_P exits the script on failure.
> > 
> > This part is fine.
> 
> Resubmitted.

I've applied your old version of that, and the corresponding autotest
change.

Cheers,
Ralf

2006-04-07  Eric Blake  <address@hidden>

        * doc/autoconf.texi (Programming in M4sh): Document that
        AS_MKDIR_P exits the script on failure.
        * lib/autotest/general.m4: Remove redundant AS_ERROR.

Index: doc/autoconf.texi
===================================================================
RCS file: /cvsroot/autoconf/autoconf/doc/autoconf.texi,v
retrieving revision 1.986
diff -u -r1.986 autoconf.texi
--- doc/autoconf.texi   6 Apr 2006 17:51:22 -0000       1.986
+++ doc/autoconf.texi   7 Apr 2006 12:31:46 -0000
@@ -9461,7 +9461,8 @@
 lack support for the @option{-p} option.  Also, @code{AS_MKDIR_P}
 succeeds if @var{file-name} is a symbolic link to an existing directory,
 even though Posix is unclear whether @samp{mkdir -p} should
-succeed in that case.
+succeed in that case.  If creation of @var{file-name} fails, exit the
+script.
 @end defmac
 
 @defmac AS_SHELL_SANITIZE
Index: lib/autotest/general.m4
===================================================================
RCS file: /cvsroot/autoconf/autoconf/lib/autotest/general.m4,v
retrieving revision 1.204
diff -u -r1.204 general.m4
--- lib/autotest/general.m4     5 Apr 2006 20:55:14 -0000       1.204
+++ lib/autotest/general.m4     7 Apr 2006 12:31:46 -0000
@@ -702,8 +702,7 @@
        rm -fr $at_group_dir
       fi
       # Be tolerant if the above `rm' was not able to remove the directory.
-      AS_MKDIR_P([$at_group_dir]) ||
-       AS_ERROR([cannot create $at_group_dir])
+      AS_MKDIR_P([$at_group_dir])
       cd $at_group_dir
       ;;
   esac