Re: autotest fails when pwd is testgroup directory

[Noah Misch]

On Wed, Apr 05, 2006 at 07:21:46AM -0600, Eric Blake wrote:
> According to Stepan Kasal on 4/1/2006 9:15 AM:

> > +++ lib/autotest/general.m4 1 Apr 2006 16:09:13 -0000       1.200
> > @@ -699,7 +699,8 @@
> >     find $at_group_dir -type d ! -perm -700 -exec chmod u+rwx \{\} \;
> >     rm -fr $at_group_dir
> >        fi
> > -      mkdir $at_group_dir ||
> > +      # Be tolerant if the above `rm' was not able to remove the directory.
> > +      AS_MKDIR_P([$at_group_dir]) ||
> >     AS_ERROR([cannot create $at_group_dir])
> 
> I just noticed that AS_MKDIR_P already does AS_ERROR (fatal to the script)
> if it fails, so the AS_ERROR in autotest/general.m4 is now redundant with
> the one built in to m4sh.m4.

Yes.

> Also, should we document AS_ERROR and friends in autoconf.texi?

I don't have an opinion on this.

> Also, AS_MKDIR_P is not threadsafe if mkdir -p is not supported, is that a
> problem?

This does not matter for Autoconf.


> 2006-04-05  Eric Blake  <address@hidden>
> 
>       * doc/autoconf.texi (Programming in M4sh): Document that
>       AS_MKDIR_P exits the script on failure.

This part is fine.

>       * lib/m4sugar/m4sh.m4 (AS_SHELL_SANITIZE, AS_MESSAGE, AS_WARN)
>       (AS_ERROR, AS_MKDIR_P, _AS_DIRNAME_PREPARE, _AS_MKDIR_P_PREPARE)
>       (_AS_TR_*PREPARE): Improve documentation.

These changes don't clarify much.

>       * lib/autotest/general.m4: Remove redundant AS_ERROR.  Cleanup
>       space followed by tab.

Keep white space cleanup separate from other changes.


You took a very simple change and expanded its diff by a factor of nine through
unrelated comment updates and white space cleanups.  Please avoid that.