Re: 17-proto-autoscan-check.patch

[Pavel Roskin]

Hello, Akim!

I was very busy during that last week, so I'm sorry that you didn't have
my "Ok" for many of your patches.

> ~/src/bison % ../ace/autoscan -A ../ace
> Name "main::line" used only once: possible typo at ../ace/autoscan line 465.
> Name "main::args" used only once: possible typo at ../ace/autoscan line 465.

What version of perl are you using?

> warning: missing AC_PROG_CXX
> warning: missing AC_PROG_LEX
> warning: missing AC_PROG_LN_S
> warning: missing AC_PROG_YACC

I don't understand what you are running. It's probably an already patched
version of autoscan, right?

You have applied a minimal patch. I hope that some of the issues have been
fixed. Please resubmit your patch for the remaining changes if there are
any.

> Pay attention that the path to autoconf is hard coded
> /home/akim/... (blush).  Some Perl programmer should copy the way
> autoheader and autoupdate look for autoconf to fix this attrocity.

I hope that it will not be hardcoded to autoscan.pl and committed on CVS
:-)

> Having autoscan find configure.in/configure.ac would be another bonus :)

May be, but

1) it should be optional
2) I don't understand what you are trying to extract from it.

> +** Autoscan macros
> +Can be introduced even before specializing macros.  It just means that
> +specializing macros will call them.  OTOH, this doubles our work,
> +since specializing macros will save us from additional typing.  But
> +the more powerful autoscan is, the better...
> +
>  * Autoconf 2.51 or later

Please put it after "Autoconf 2.51 or later". Autoscan is not an essential
tool - it will never generate a complete configure.ac, no matter how
"powerful" it is.

>  # Reference these variables to pacify perl -w.
> -undef %identifiers_macros;
> -undef %makevars_macros;
> -undef %programs_macros;
> +%identifiers_macros = ();
> +%makevars_macros = ();
> +%programs_macros = ();
> +%needed_macros = ();

I'm surprised. Your Perl must be either very old or very new. I thought
"undef" is perfectly valid and safe here.

> +&check_configure_ac ('configure.in');

How about configure.ac ?

>    &output_programs;
> +  &output_libraries;
>    &output_headers;
>    &output_identifiers;
>    &output_functions;

It's too much for one patch, sorry.

> +  foreach $macro (sort keys %needed_macros)
> +    {
> +      print STDERR "warning: missing $macro\n";
> +    }
>  }

Good idea.

Regards,
Pavel Roskin