autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

FYI: Fix for autoconf -Wall.


From: Pavel Roskin
Subject: FYI: Fix for autoconf -Wall.
Date: Fri, 1 Dec 2000 20:38:57 -0500 (EST)

Hello!

It's an obvious hole in our testsuite - "autoconf -Wall" would print
warnings even on the harmless

AC_INIT
AC_OUTPUT

and nobody notices that. We had two cases of escaped backquote in
AC_MSG_ERROR. While testing my fix I also found a minor bug in the output
of config.status - it didn't display the unrecognized option while
reporing it.

Regards,
Pavel Roskin

______________________
Index: ChangeLog
--- ChangeLog   Fri Dec  1 19:47:55 2000
+++ ChangeLog   Fri Dec  1 20:25:49 2000
@@ -2,2 +2,7 @@

+       * acgeneral.m4 (_AC_OUTPUT_CONFIG_STATUS): Don't escape
+       backquotes in AC_MSG_ERROR. Fixed error message.
+
+2000-12-01  Pavel Roskin  <address@hidden>
+
        * tests/atgeneral.m4 (AT_INIT): Use ${CONFIG_SHELL-/bin/sh}
Index: acgeneral.m4
--- acgeneral.m4        Wed Nov 29 13:30:52 2000
+++ acgeneral.m4        Fri Dec  1 20:19:39 2000
@@ -3919,8 +3919,8 @@
     echo "$ac_cs_version"; exit 0 ;;
   --he | --h)
     # Conflict between --help and --header
-    AC_MSG_ERROR([ambiguous option: $ac_option
-Try \`$[0] --help' for more information.]);;
+    AC_MSG_ERROR([ambiguous option: $[1]
+Try `$[0] --help' for more information.]);;
   --help | --hel | -h )
     echo "$ac_cs_usage"; exit 0 ;;
   --debug | --d* | -d )
@@ -3954,7 +3954,7 @@

   # This is an error.
   -*) AC_MSG_ERROR([unrecognized option: $[1]
-Try \`$[0] --help' for more information.]) ;;
+Try `$[0] --help' for more information.]) ;;
   *) AC_MSG_ERROR([invalid argument: $[1]]);;
   esac
   shift
______________________





reply via email to

[Prev in Thread] Current Thread [Next in Thread]