Re: Bug in largefile.m4

[Paul Eggert]

> From: address@hidden
> Date: Sat, 2 Dec 2000 01:26:47 +0100 (MET)
> 
> I just started to steal code from your autoconf
> and found that it contains a minor bug:
> 
> If you don't set CC= nothing will work...
> This patch helps:
> 
> 49c925
> <           [ac_save_CC="$CC"
> ---
> >           [ac_save_CC="${CC-cc}"

Thanks for the bug report.  Your workaround doesn't look quite right,
though, since AC_SYS_LARGEFILE shouldn't decide what CC should be.
Here's what I think is a better patch.  I'll CC: this message to
address@hidden, since this code (in a slightly different
form) will be in the next autoconf release.

2000-12-01  Paul Eggert  <address@hidden>

        * m4/largefile.m4 (AC_SYS_LARGEFILE): Require AC_PROG_CC.

===================================================================
RCS file: m4/largefile.m4,v
retrieving revision 1.15
retrieving revision 1.16
diff -pu -r1.15 -r1.16
--- m4/largefile.m4     2000/11/15 20:08:53     1.15
+++ m4/largefile.m4     2000/12/02 00:41:26     1.16
@@ -32,7 +32,8 @@ AC_DEFUN(AC_SYS_LARGEFILE_MACRO_VALUE,
    fi])
 
 AC_DEFUN(AC_SYS_LARGEFILE,
-  [AC_ARG_ENABLE(largefile,
+  [AC_REQUIRE([AC_PROG_CC])
+   AC_ARG_ENABLE(largefile,
      [  --disable-largefile     omit support for large files])
    if test "$enable_largefile" != no; then