ly: updates to hel-arabic.ly (issue 349810043 by address@hidden)

[lilypond]

I don’t know anything about arabic music but there are some changes that
look strange to me.


https://codereview.appspot.com/349810043/diff/1/ly/hel-arabic.ly
File ly/hel-arabic.ly (left):

https://codereview.appspot.com/349810043/diff/1/ly/hel-arabic.ly#oldcode73
ly/hel-arabic.ly:73: %% Sajakar: c' d' edb' f' g' ab' b' c'' c'' bb' a'
g' f' edb' d' c'
Is this “never used” in the same way as locrian mode, i. e. only in
theory?

https://codereview.appspot.com/349810043/diff/1/ly/hel-arabic.ly#oldcode248
ly/hel-arabic.ly:248: %% Irak: bdb c d edb f g a bdb bb a g f edb d c
bdb
Are these identical to “rast” in the same way ionian is to major? Then I
wouldn’t delete them. Maybe simply #(define iraq rast) or iraq = \rast

https://codereview.appspot.com/349810043/diff/1/ly/hel-arabic.ly#oldcode334
ly/hel-arabic.ly:334: major = #`(
Does hel-arabic.ly *replace* scale-definitions-init.ly? If not, these
definitions are redundant.

https://codereview.appspot.com/349810043/diff/1/ly/hel-arabic.ly
File ly/hel-arabic.ly (right):

https://codereview.appspot.com/349810043/diff/1/ly/hel-arabic.ly#newcode158
ly/hel-arabic.ly:158: (4 . FLAT)
Should be ,FLAT (with comma). Or ,SHARP == 1/2?

https://codereview.appspot.com/349810043/