Re: ly: updates to hel-arabic.ly (issue 349810043 by address@hidden)

[pkxgnugitcl]

Reviewers: Malte Meyn,

Message:
On 2018/12/12 15:44:15, hassan.elfatihi_free.fr wrote:
> Hello

> I am hassan el fatihi author of hel-arabic.ly.

> I corrected some minimal errors.

> 20 makams are working properly. I can give you examples if you wish.

> I use the hel-arabic.ly file since 2009.

> Makam sajkar is from the rast family, with slight modifications

> The makam irak notes can be written with the key of rast: \ key c \
rast (same
> thing for

> rahatalarouah and alboustankar).

> If you need more information, I am at your disposal.

> Thank you

Hassan can you answer the specific questions from Malte please?

I cannot answer them.

You can reply directly to Malte in his entry above. I can them make any
adjustments as necessary.

Regards

James

Description:
ly: updates to hel-arabic.ly

Changes suggested by Hassan Elfatihi

Minor Typos fixed

irak, rahatalarouah and alboustankar
are all redundant as they are all the same
mode as 'rast'.

Sajkar mode is never used so this has been
removed.

Please review this at https://codereview.appspot.com/349810043/

Affected files (+3, -53 lines):
  M ly/hel-arabic.ly


Index: ly/hel-arabic.ly
diff --git a/ly/hel-arabic.ly b/ly/hel-arabic.ly
index  
890ae908b18345ab7216c6197a50e6212b9e4b57..dc6141334f876c00da9a64d066fba02f8f6938cf  
100644
--- a/ly/hel-arabic.ly
+++ b/ly/hel-arabic.ly
@@ -66,18 +66,6 @@ souznak = #`(
   (3 . ,NATURAL)
   (4 . ,NATURAL)
   (5 . ,FLAT)
- %(6 . ,SEMI-FLAT)
-  (6 . ,NATURAL)
-)
-
-%% Sajakar: c' d' edb' f' g' ab' b' c'' c'' bb' a' g' f' edb' d' c'
-sajkar = #`(
-  (0 . ,NATURAL)
-  (1 . ,NATURAL)
-  (2 . ,SEMI-FLAT)
-  (3 . ,NATURAL)
-  (4 . ,NATURAL)
-  (5 . ,FLAT)
   (6 . ,NATURAL)
 )

@@ -132,7 +120,7 @@ nakriz = #`(
   (2 . ,FLAT)
   (3 . ,SHARP)
   (4 . ,NATURAL)
-  (5 . ,FLAT)
+  (5 . ,NATURAL)
   (6 . ,FLAT)
 )

@@ -167,7 +155,7 @@ karjkhar =  #`(
   (1 . ,SEMI-FLAT)
   (2 . ,FLAT)
   (3 . ,NATURAL)
-  (4 . 1/2)
+  (4 . FLAT)
   (5 . ,NATURAL)
   (6 . ,FLAT)
 )
@@ -217,7 +205,7 @@ huzam =  #`(
   (1 . ,SEMI-FLAT)
   (2 . ,SEMI-FLAT)
   (3 . ,SEMI-FLAT)
-  (4 . ,SEMI-FLAT)
+  (4 . ,SEMI-SHARP)
   (5 . ,SEMI-FLAT)
   (6 . ,SEMI-FLAT)
 )
@@ -245,44 +233,6 @@ yakah = #`(
   (6 . ,SEMI-FLAT)
 )

-%% Irak: bdb c d edb f g a bdb bb a g f edb d c bdb
-%% Irak: en do: c ddb edb f gdb adb c cdb bdb adb gdb f edb ddb c
-iraq = #`(
-  (0 . ,NATURAL)
-  (1 . ,SEMI-FLAT)
-  (2 . ,SEMI-FLAT)
-  (3 . ,NATURAL)
-  (4 . ,SEMI-FLAT)
-  (5 . ,SEMI-FLAT)
-  (6 . ,SEMI-FLAT)
-)
-
-%% Rahatalarouah: bdb c'd' eb' fd' g' a' bdb' bdb' a' g' fd' eb' d' c' bdb'
-%% Rahatalarouah: en do : c' ddb' edb' fdd' gdd' adb' bdb' c'' c'' bdb'  
adb' gdd'
-%% fdd' edb' ddb' c'
-rahatalarouah = #`(
-  (0 . ,NATURAL)
-  (1 . ,SEMI-FLAT)
-  (2 . ,SEMI-FLAT)
-  (3 . ,SEMI-FLAT)
-  (4 . ,SEMI-SHARP)
-  (5 . ,SEMI-FLAT)
-  (6 . ,SEMI-FLAT)
-)
-
-%% Alboustankar: bdb c d edb f gb a bb bb a gb f edb d c bdb
-%% Alboustankar: c ddb edb f gdb a bdb cdb cdb bdb a gdb f edb ddb c
-alboustankar = #`(
-  (0 . ,NATURAL)
-  (1 . ,SEMI-FLAT)
-  (2 . ,SEMI-FLAT)
-  (3 . ,SEMI-FLAT)
-  (4 . ,SEMI-SHARP)
-  (5 . ,SEMI-FLAT)
-  (6 . ,SEMI-FLAT)
-)
-
-
 %% Hizaz Avec sib et mib: d' eb' fd' g' a' bdb' c'' d'' d'' c''bb' a' g'  
fd' eb' d'
 %% Hizaz: en do: c db e f g adb bb c c bb ab g f e db c
 hizaz = #`(