[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: patch: global -u on win32 with src root at drive root
From: |
Shigio YAMAGUCHI |
Subject: |
Re: patch: global -u on win32 with src root at drive root |
Date: |
Mon, 19 Oct 2009 10:29:45 +0900 |
Hi,
Changing the source code for Windows environment is OK.
But I am anxious why the directory name is not included
in the variable 'root'. Should not we fix the cause?
> Hi,
>
> i compiled global on win32 and tried it with a source tree which starts
> directly at the drive level (root='D:'). In this case the chdir which
> takes care that the search in 'global -u' starts at the root of the src
> tree does not work on windows if there's no '/' at the end of the path.
> If you change root='D:' to root='D:/' its working. So i changed
> chdir(root) to chdir(get_root_with_slash()) in order to fix this. I
> don't think this will cause problems for unix systems.
>
> Could you consider adding the attached patch to the global sources?
Regards,
Shigio
--
Shigio YAMAGUCHI <address@hidden>
PGP fingerprint: D1CB 0B89 B346 4AB6 5663 C4B6 3CA5 BBB3 57BE DDA3
- patch: global -u on win32 with src root at drive root, Kai Tetzlaff, 2009/10/18
- Re: patch: global -u on win32 with src root at drive root,
Shigio YAMAGUCHI <=
- Re: patch: global -u on win32 with src root at drive root, Kai Tetzlaff, 2009/10/19
- Re: patch: global -u on win32 with src root at drive root, Shigio YAMAGUCHI, 2009/10/19
- Re: patch: global -u on win32 with src root at drive root, Kai Tetzlaff, 2009/10/19
- Re: patch: global -u on win32 with src root at drive root, Shigio YAMAGUCHI, 2009/10/19
- Re: patch: global -u on win32 with src root at drive root, Shigio YAMAGUCHI, 2009/10/20
- Re: patch: global -u on win32 with src root at drive root, Kai Tetzlaff, 2009/10/20
- Re: patch: global -u on win32 with src root at drive root, Shigio YAMAGUCHI, 2009/10/20
- Re: patch: global -u on win32 with src root at drive root, Kai Tetzlaff, 2009/10/23
- Re: patch: global -u on win32 with src root at drive root, Shigio YAMAGUCHI, 2009/10/23