[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parent
From: |
Eli Zaretskii |
Subject: |
bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching |
Date: |
Sat, 16 Sep 2023 08:54:32 +0300 |
> Date: Fri, 15 Sep 2023 16:35:55 +0300
> Cc: Eli Zaretskii <eliz@gnu.org>, Yuan Fu <casouri@gmail.com>,
> Theodor Thornhill <theo@thornhill.no>,
> Jostein Kjønigsen <jostein@kjonigsen.net>, btuin@mailo.com,
> 65470@debbugs.gnu.org
> From: Dmitry Gutov <dmitry@gutov.dev>
>
> On 15/09/2023 15:11, Jostein Kjønigsen wrote:
> >> This patch seems to fix that and bring JSX syntax highlighting back:
> >>
> >> diff --git a/lisp/progmodes/typescript-ts-mode.el
> >> b/lisp/progmodes/typescript-ts-mode.el
> >> index 57382c9cb31..7108ff49b28 100644
> >> --- a/lisp/progmodes/typescript-ts-mode.el
> >> +++ b/lisp/progmodes/typescript-ts-mode.el
> >> @@ -163,7 +163,7 @@ tsx-ts-mode--font-lock-compatibility-bb1f97b
> >> ;; but then raises an error if the wrong node type is used. So it is
> >> ;; important to check with the new node type (member_expression)
> >> (condition-case nil
> >> - (progn (treesit-query-capture language '((member_expression)
> >> @capture))
> >> + (progn (treesit-query-capture language '(jsx_opening_element
> >> (member_expression) @capture))
> >> '((jsx_opening_element
> >> [(member_expression (identifier)) (identifier)]
> >> @typescript-ts-jsx-tag-face)
> >>
> > I really don’t know this part of the code very well. If you’ve identified
> > an issue/bug for a specific TSX use-case, and found a fix for it, I have no
> > objections to it being applied.
>
> No problem, pushed that to emacs-29, thanks.
This seems to cause:
INFO Scraping files for loaddefs...85%
typescript-ts-mode:0: Warning: Not registering prefix "ts". Affects:
("tsx-ts-mode--indent-compatibility-b893426"
"tsx-ts-mode--font-lock-compatibility-bb1f97b" "tsx-ts--s-p-query"
"tsx-ts--syntax-propertize" "ts-ts--s-p-query" "ts-ts--syntax-propertize"
"ts-ts--syntax-propertize-captures")
Stefan, what do we usually do with such warnings?
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching, (continued)
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching, Jostein Kjønigsen, 2023/09/05
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching, Eli Zaretskii, 2023/09/07
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching, Dmitry Gutov, 2023/09/07
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching, Jostein Kjønigsen, 2023/09/11
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching, Dmitry Gutov, 2023/09/11
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching, Jostein Kjønigsen, 2023/09/12
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching, Dmitry Gutov, 2023/09/12
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching, Jostein Kjønigsen, 2023/09/15
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching, Dmitry Gutov, 2023/09/15
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching,
Eli Zaretskii <=
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching, Eli Zaretskii, 2023/09/16
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching, Eli Zaretskii, 2023/09/16
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching, Dmitry Gutov, 2023/09/16
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching, Stefan Monnier, 2023/09/16
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching, Dmitry Gutov, 2023/09/16
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching, Eli Zaretskii, 2023/09/17