bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parent


From: Eli Zaretskii
Subject: bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching
Date: Thu, 07 Sep 2023 11:59:37 +0300

> From: Jostein Kjønigsen <jostein@secure.kjonigsen.net>
> Date: Tue, 5 Sep 2023 21:31:25 +0200
> Cc: Eli Zaretskii <eliz@gnu.org>,
>  Yuan Fu <casouri@gmail.com>,
>  Theodor Thornhill <theo@thornhill.no>,
>  Jostein Kjønigsen <jostein@kjonigsen.net>,
>  btuin@mailo.com,
>  65470@debbugs.gnu.org
> 
> Sorry for the somewhat slow response on this. Life has been busy for me as 
> well :)
> 
> Based on the infamous “copy, paste & adapt” methodology I’ve come up with a 
> patch for typescript-ts-mode and tsx-ts-mode which seems to work for the 
> simple test case provided above.
> 
> However the patch for js-ts-mode has lots of … interesting stuff about jsx I 
> have not included, for no other reason than not understanding what type of 
> use-cases they are meant to support.
> 
> If someone can provide me some examples for the JSX use-cases, I can try to 
> make room for TSX-variants of the same code.
> 
> The patch so far is attached. It’s intentionally -not- optimized to leave 
> room for TSX cases which may arise, so hopefully no need to nitpick this yet.

Thanks, Jostein.

Any objections to my installing this on the emacs-29 branch, anyone?





reply via email to

[Prev in Thread] Current Thread [Next in Thread]