[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parent
From: |
Jostein Kjønigsen |
Subject: |
bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching |
Date: |
Tue, 12 Sep 2023 08:29:41 +0200 |
On 12 Sep 2023, at 00:23, Dmitry Gutov <dmitry@gutov.dev> wrote:
>
> Hi Jostein!
>
> The patch looks good overall (though I haven't tested it).
>
> On 11/09/2023 22:37, Jostein Kjønigsen wrote:
>
> > So to fix that, I’ve tried to anchor the query to top-level constructs
> > which typically does not nest. Looking at the query for js.el, I can only
> > assume that you were trying to too solve the same problem, Dmitry?
>
> That's right.
>
>> + ((arguments (jsx_element) @jsx))
>> + ((parenthesized_expression (jsx_element)
>> @jsx))))))
>
> These two contexts actually seem missing in my patch for js-ts-mode. :-)
>
> OTOH, it seems like the ones that _are_ included there, are missing here.
> Don't they?
>
> ((variable_declarator value: (jsx_element) @jsx))
>
> corresponds do
>
> let v = <div>...</div>
>
> ((assignment_expression right: (jsx_element) @jsx))
>
> corresponds do
>
> v = <p>...<p>
>
> (with variable declared previously), and
>
> ((return_statement (jsx_element) @jsx))
>
> corresponds to
>
> function f() {
> return <div>...<div>;
> }
Good feedback. I’ve tested and included those as well. Attached is a new patch.
0001-typescript-ts-mode-Fix-syntax-properties-for-regexp-.patch
Description: Binary data
—
Jostein
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching, BTuin, 2023/09/01
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching, Jostein Kjønigsen, 2023/09/05
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching, Eli Zaretskii, 2023/09/07
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching, Dmitry Gutov, 2023/09/07
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching, Jostein Kjønigsen, 2023/09/11
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching, Dmitry Gutov, 2023/09/11
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching,
Jostein Kjønigsen <=
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching, Dmitry Gutov, 2023/09/12
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching, Jostein Kjønigsen, 2023/09/15
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching, Dmitry Gutov, 2023/09/15
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching, Eli Zaretskii, 2023/09/16
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching, Eli Zaretskii, 2023/09/16
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching, Eli Zaretskii, 2023/09/16
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching, Dmitry Gutov, 2023/09/16
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching, Stefan Monnier, 2023/09/16
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching, Dmitry Gutov, 2023/09/16
- bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching, Eli Zaretskii, 2023/09/17