Re: wget2 | ^C causes a Core dump (#573)

[@rockdaboot]

Tim Rühsen commented:


Ah, but your second URL creates this error when built with ASAN:
```
HTTP response 200 OK 
[https://download.java.net/java/early_access/jdk18/26/GPL/openjdk-18-ea+26_linux-aarch64_bin.tar.gz]
Unexpected body length 40729655.
08.181324.330 Removing (null)
wget.c:1676:11: runtime error: null pointer passed as argument 1, which is 
declared to never be null
/usr/include/unistd.h:837:48: note: nonnull attribute specified here
    #0 0x4e4561 in process_response_header /home/tim/src/wget2/src/wget.c:1676:4
    #1 0x4deb63 in downloader_thread /home/tim/src/wget2/src/wget.c:2353:8
    #2 0x7fd0c9c4dead in start_thread nptl/pthread_create.c:463:8
    #3 0x7fd0c9a11a5e in __clone 
misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:95

SUMMARY: UndefinedBehaviorSanitizer: invalid-null-argument wget.c:1676:11 in 
```
(I used wget2 -d ...)

The difference seems to be that the first URL that you mention is downloaded 
via HTTP/2. The second URL is downloaded vias HTTP/1.1.

Hopefully will find time to fix this in the next 1-2 weeks (anyone else can do 
that as well - seems to be very simple to fix).

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/-/issues/573#note_757486629
You're receiving this email because of your account on gitlab.com.