[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: wget2 | ^C causes a Core dump (#573)
From: |
@rockdaboot |
Subject: |
Re: wget2 | ^C causes a Core dump (#573) |
Date: |
Sun, 12 Dec 2021 17:12:31 +0000 |
Tim Rühsen commented:
I don't remember the exact reason why I used abort() instead of exit().
Maybe it was due to exit() sometimes just doesn't work as expected. E.g. when
called from a signal handler with some libc implementations. I should have
documented this but :shrug:.
Ideally, the first ctrl-C should terminate wget2. But as every thread has it's
own memory buffers, they are just "informed" (with terminate=1) that they
should clean up and stop asap. But threads may hang for several reasons (e.g.
waiting for I/O timeout) - that's why there is a hard stop on the second ctrl-c.
Anyway, I had not issues locally with exit(), so let's try it. A commit that
replaces abort() with exit() on the second ctrl-c has been pushed to master.
--
Reply to this email directly or view it on GitLab:
https://gitlab.com/gnuwget/wget2/-/issues/573#note_768854082
You're receiving this email because of your account on gitlab.com.
- Re: wget2 | ^C causes a Core dump (#573), (continued)
- Re: wget2 | ^C causes a Core dump (#573), @rockdaboot, 2021/12/08
- Re: wget2 | ^C causes a Core dump (#573), @rockdaboot, 2021/12/08
- Re: wget2 | ^C causes a Core dump (#573), @piotr.zygielo, 2021/12/08
- Re: wget2 | ^C causes a Core dump (#573), @piotr.zygielo, 2021/12/08
- Re: wget2 | ^C causes a Core dump (#573), @piotr.zygielo, 2021/12/08
- Re: wget2 | ^C causes a Core dump (#573), @piotr.zygielo, 2021/12/08
- Re: wget2 | ^C causes a Core dump (#573), @rockdaboot, 2021/12/10
- Re: wget2 | ^C causes a Core dump (#573), @piotr.zygielo, 2021/12/10
- Re: wget2 | ^C causes a Core dump (#573), @rockdaboot, 2021/12/11
- Re: wget2 | ^C causes a Core dump (#573),
@rockdaboot <=
- Re: wget2 | ^C causes a Core dump (#573), John Boero (@boeroboy), 2021/12/22
- Re: wget2 | ^C causes a Core dump (#573), John Boero (@boeroboy), 2021/12/22
- Re: wget2 | ^C causes a Core dump (#573), @rockdaboot, 2021/12/24