[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Wget-dev] wget2 | --no-if-modified-since implementation & tests for

From: Tim Rühsen
Subject: Re: [Wget-dev] wget2 | --no-if-modified-since implementation & tests for both --no-if-modified-since and -N (!439)
Date: Thu, 22 Aug 2019 08:35:29 +0000

Tim Rühsen commented:

WGET_GCC_NONNULL_ALL is a gcc attribute to functions, saying that all pointer 
arguments *should* never be NULL. Static analyzers like scan-build take 
advantage of it. Downside: gcc optimizes any checks against NULL away within 
the function. So it's pretty dangerous in case the analyzer fails or you don't 
use a analyzer at all. It works very good together with clang's _Nullable. That 
is to tag a pointer (e.g. returned by a function) as 'may be NULL'. If such a 
pointer is used as a NONNULL param without prior checking, scan-build / clang 
will complain. That's pretty neat and gcc doesn't have it.

> Before merge I would like to uncomment them.

OK, I approved already, so you can merge whenever you want.

Reply to this email directly or view it on GitLab: 
You're receiving this email because of your account on gitlab.com.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]