[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Wget-dev] wget2 | --no-if-modified-since implementation & tests for

From: DalmeGNU
Subject: Re: [Wget-dev] wget2 | --no-if-modified-since implementation & tests for both --no-if-modified-since and -N (!439)
Date: Wed, 21 Aug 2019 11:16:54 +0000

DalmeGNU commented:

Looks ready. However, I have some questions / comments:
- We may add WGET_GCC_NONNULL_ALL to get_file_lmtime(), as I don't know what is 
this for I cannot say.
- I haven't written tests for `--accept-regex & --reject-regex`, I think the 
ones for `--accept & --reject` are enough
- There are two commented tests in `test-include-and-exclude-directories.c`. 
I've run those and they passed, but until !440 is merged they break the 
pipeline. Before merge I would like to uncomment them.
- Pipeline has 4 failed jobs, but it's OK

Reply to this email directly or view it on GitLab: 
You're receiving this email because of your account on gitlab.com.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]