wget-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Wget-dev] wget2 | Add TLS 1.3 post-handshake authentication (!418)


From: Tim Rühsen
Subject: Re: [Wget-dev] wget2 | Add TLS 1.3 post-handshake authentication (!418)
Date: Wed, 24 Apr 2019 12:58:47 +0000



LGTM, very good work !

There is just a small confusion with your email address. FSF added you as 
address@hidden (and I put that into AUTHORS file) but your commits have 
address@hidden as author. Maybe you can use kumarmallikarjuna1 for Wget2 
commits as well !? If you decide for this one, please change the authors in the 
commits as well and force push again. If you decide for *314, please amend the 
AUTHORS file and add it to your commit.

Before you push, could you clear the pipeline caches ? Just wondering if the 
MinGW runner then succeeds. It's in `CICD/pipelines/clear runner caches` of 
your Gitlab account.

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/merge_requests/418#note_163833610
You're receiving this email because of your account on gitlab.com.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]