wget-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Wget-dev] [PATCH] * src/ftp.c (ftp_retrieve_glob): Refactor to prevent


From: Darshit Shah
Subject: [Wget-dev] [PATCH] * src/ftp.c (ftp_retrieve_glob): Refactor to prevent looping over listing multiple times
Date: Tue, 13 Nov 2018 00:43:59 +0100
User-agent: NeoMutt/20180716

I noticed that the ftp_retrieve_glob() function would loop over the FTP Listing
file multiple times when checking for accepts / rejects / globs. In this patch,
I've refactored the function so that we iterate through all the files only
once.

According to me, the refactor is simple and without errors. But we're close to
making a new release so I'd prefer another pair of eyes look through this once.

-- 
Thanking You,
Darshit Shah
PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6

Attachment: 0001-src-ftp.c-ftp_retrieve_glob-Refactor-to-prevent-loop.patch
Description: Text document

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]