[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Wget-dev] [PATCH] * src/ftp.c (ftp_retrieve_glob): Refactor to prev
|
From: |
Tim Rühsen |
|
Subject: |
Re: [Wget-dev] [PATCH] * src/ftp.c (ftp_retrieve_glob): Refactor to prevent looping over listing multiple times |
|
Date: |
Tue, 13 Nov 2018 11:23:22 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 |
LGTM
On 11/13/18 12:43 AM, Darshit Shah wrote:
> I noticed that the ftp_retrieve_glob() function would loop over the FTP
> Listing
> file multiple times when checking for accepts / rejects / globs. In this
> patch,
> I've refactored the function so that we iterate through all the files only
> once.
>
> According to me, the refactor is simple and without errors. But we're close to
> making a new release so I'd prefer another pair of eyes look through this
> once.
>
signature.asc
Description: OpenPGP digital signature