txr-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Txr-users] GC bug fixed in GIT.


From: Kaz Kylheku
Subject: [Txr-users] GC bug fixed in GIT.
Date: Sat, 15 Oct 2011 17:08:57 -0700
User-agent: Roundcube Webmail/0.4


The following patch fixes a serious GC problem that was exposed under GCC 4.5.2,
x86_64 target.

http://git.savannah.gnu.org/cgit/txr.git/commit/?id=bfd057506984287e9ffc3adfa712f44586b7ca7d

The gist of it is that the machine registers were being excluded from the root
pointer scan of the garbage collector.

The functions in the garbage collector are heavily inlined, and the logic
was depending on the order of variables on the combined stack frame
of the inlined functions.

The test suite should flush out this kind of thing and it did its job.
This is why tests are run with "txr --gc-debug" which performs a garbage
collection before every memory allocation (sloooow).

I should change the wording in the configure script to encourage people
to run "make tests" before "make install".

Cheers ...




reply via email to

[Prev in Thread] Current Thread [Next in Thread]