Expanding macros for readability.

[Jeremy Whiting]

Luke,

How does this patch look? It  seems to work fine here.

thanks,
Jeremy

On Fri, May 8, 2015 at 11:50 AM, Jeremy Whiting <jpwhiting at kde.org> wrote:
> The strange mismatch between having a newline after the return value
> and not seems to be coming from the indent call in README.style. I had
> a newline after all of the return types when I wrote it, but indent
> put the one line function function names on the same line as the
> return type. If I put them all on the same line, indent doesn't add
> newlines in the ones that aren't single line functions. This time I
> left the function name on the same line, so they are all that way
> after indent is ran on the file.
>
> Anyway, if we need to update the indent call in README.style to
> reflect how it should be in the sources that's fine with me. Here's an
> updated patch that expands the int and str get and set macros.
>
> thanks,
> Jeremy
>
> On Thu, May 7, 2015 at 9:31 PM, Luke Yelavich
> <luke.yelavich at canonical.com> wrote:
>> On Fri, May 08, 2015 at 11:03:47AM AEST, Jeremy Whiting wrote:
>>> Hey all, I discussed the macros a bit with Luke on irc this evening
>>> and thought about expanding them into helper methods. I've attached a
>>> patch that does that for SPD_SET_COMMAND_INT to see how it could be.
>>> If you like this I'll do the same for the other macros to make
>>> libspeechd more readable, greppable, etc.
>>
>> Yeah, this looks good. I see inconsistancy in the style of this patch, 
>> mostly to do with the formatting of the method definitions, i.e some have 
>> the return type on a separate line and some don't.
>>
>> Feel free to go ahead and refactor the other macros with the style 
>> consistancy pointer in mind. :)
>>
>> Thanks
>>
>> Luke
>>
>> _______________________________________________
>> Speechd mailing list
>> Speechd at lists.freebsoft.org
>> http://lists.freebsoft.org/mailman/listinfo/speechd