[PATCH 1/1] Add module_semaphore_free() to destroy semaphore...

[Trevor Saunders]

On Fri, Dec 09, 2011 at 06:05:33AM +0400, sub wrote:
>         
> >>> you mean just to remove module_semaphore_init completely and use
> >>> static sem_t my_sem;
> >>> in the modules instead of
> >>> static sem_t *my_sem;
> >>
> >> yup :)
> 
> > Ok.
> > Anatol, would you mind resubmitting your patch based on Trev's comments?
> 
> Ok.
> 
> To tell the truth , the use of platform-specific functions instead of the 
> wrappers (such as module_semaphore_...) is strange to me.

I wouldn't call an api provided by pthread's platform specific, and
there's no need for a wrapper so it shouldn't exist.

> I proceeded  from the assumption that the design of a module API develops 
> towards wrapping the platform specific calls, to say nothing of the hiding 
> the semaphore's implementation.

I'm not sure what your getting at here.  The purpose of module_foo() is
to provide functions that are useful in multiple modules, but if there's
no need for a utility function then there's no need for a module_foo()

Trev

> 
>     Anatol.
> _______________________________________________
> Speechd mailing list
> Speechd at lists.freebsoft.org
> http://lists.freebsoft.org/mailman/listinfo/speechd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20111208/b244d91a/attachment.pgp>