[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 03/09] replace EPunctMode with SPDPunctuation
From: |
Andrei Kholodnyi |
Subject: |
[PATCH 03/09] replace EPunctMode with SPDPunctuation |
Date: |
Sun, 3 Oct 2010 21:48:53 +0200 |
> speechd_types.h is for data types that are shared between the server and
> modules. ?I feel that merging the data types from the API into this file
> as well breaks the separation that we need to keep between the code for
> the API and the rest of the project. ?Also it makes keeping the API's
> current/revision/age numbers correct confusing at best.
> the separation that we need to keep between the code for the API and the rest
> of the project.
Could you please explain what does this "separation" mean and why do
you need this "separation"?
IMO we do not need it at all, since these are the same data moving
back and forth.
you have
data 1 (client) -> marshaling- > demarshaling -> data 2 (server)
data 1 = data2 is the same data.
at the moment the same data (data 1 and data 2) in the speech-dispatcher
are represented by different data types on client/server side.
e.g. SPDPunctuation/EPunctMode, SPDPriority/int and so on.
And this makes no sense to me.
If I'd follow your "separation needs" I'd expect e.g. having different
data types e.g. by socket programming on client/server side.
But they are the same, William.
I have SPDPunctuation data on my client side,
I send it over network to the server, it arrives on the server side,
what type of data should I expect to get?
- [PATCH 03/09] replace EPunctMode with SPDPunctuation, (continued)
- [PATCH 03/09] replace EPunctMode with SPDPunctuation, Andrei Kholodnyi, 2010/10/01
- [PATCH 04/09] replace ECapLetRecogn with SPDCapitalLetters, Andrei Kholodnyi, 2010/10/01
- [PATCH 05/09] replace ESpellMode with SPDSpelling, Andrei Kholodnyi, 2010/10/01
- [PATCH 06/09] replace EVoiceType with SPDVoiceType, Andrei Kholodnyi, 2010/10/01
- [PATCH 07/09] replace VoiceDescription with SPDVoice, Andrei Kholodnyi, 2010/10/01
- [PATCH 08/09] replace ENotification with SPDNotification, Andrei Kholodnyi, 2010/10/01
- [PATCH 09/09] replace int ssml_mode with SPDDataMode, Andrei Kholodnyi, 2010/10/01
- [PATCH 03/09] replace EPunctMode with SPDPunctuation, William Hubbs, 2010/10/02
- [PATCH 03/09] replace EPunctMode with SPDPunctuation, Andrei Kholodnyi, 2010/10/02
- [PATCH 03/09] replace EPunctMode with SPDPunctuation, William Hubbs, 2010/10/03
- [PATCH 03/09] replace EPunctMode with SPDPunctuation,
Andrei Kholodnyi <=
- question about speech-dispatcher and speakup in maverick, mike cutie and maia, 2010/10/03
- [orca-list] question about speech-dispatcher and speakup in maverick, Bill Cox, 2010/10/03
- [orca-list] question about speech-dispatcher and speakup in maverick, Willem van der Walt, 2010/10/04
- [PATCH 03/09] replace EPunctMode with SPDPunctuation, William Hubbs, 2010/10/03
- [PATCH 03/09] replace EPunctMode with SPDPunctuation, Andrei Kholodnyi, 2010/10/04
[PATCH 02/09] replace ibmtts_voice_enum_to_str with spd_voice2str, William Hubbs, 2010/10/02
[PATCH 01/09] remove flite_set_voice, William Hubbs, 2010/10/01