[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 03/09] replace EPunctMode with SPDPunctuation
From: |
William Hubbs |
Subject: |
[PATCH 03/09] replace EPunctMode with SPDPunctuation |
Date: |
Sun, 3 Oct 2010 13:18:11 -0500 |
On Sun, Oct 03, 2010 at 02:22:47AM +0200, Andrei Kholodnyi wrote:
> > I don't have the message in front of me right now, but I distinctly remember
> > Hynek making a statement a while back that the API's should not use any
> > of the code from the server or modules and should just do their own
> > thing based on the documentation. ?Because of that, I am going to nak
> > all of these patches. ?We need to keep a separation between client code
> > (src/api/* and src/clients/*) and the rest of the tree.
>
> What has API to do with data types?
speechd_types.h is for data types that are shared between the server and
modules. I feel that merging the data types from the API into this file
as well breaks the separation that we need to keep between the code for
the API and the rest of the project. Also it makes keeping the API's
current/revision/age numbers correct confusing at best.
William
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL:
<http://lists.freebsoft.org/pipermail/speechd/attachments/20101003/e03e3ad6/attachment.pgp>
- [PATCH 02/09] replace ibmtts_voice_enum_to_str with spd_voice2str, (continued)
- [PATCH 02/09] replace ibmtts_voice_enum_to_str with spd_voice2str, Andrei Kholodnyi, 2010/10/01
- [PATCH 03/09] replace EPunctMode with SPDPunctuation, Andrei Kholodnyi, 2010/10/01
- [PATCH 04/09] replace ECapLetRecogn with SPDCapitalLetters, Andrei Kholodnyi, 2010/10/01
- [PATCH 05/09] replace ESpellMode with SPDSpelling, Andrei Kholodnyi, 2010/10/01
- [PATCH 06/09] replace EVoiceType with SPDVoiceType, Andrei Kholodnyi, 2010/10/01
- [PATCH 07/09] replace VoiceDescription with SPDVoice, Andrei Kholodnyi, 2010/10/01
- [PATCH 08/09] replace ENotification with SPDNotification, Andrei Kholodnyi, 2010/10/01
- [PATCH 09/09] replace int ssml_mode with SPDDataMode, Andrei Kholodnyi, 2010/10/01
- [PATCH 03/09] replace EPunctMode with SPDPunctuation, William Hubbs, 2010/10/02
- [PATCH 03/09] replace EPunctMode with SPDPunctuation, Andrei Kholodnyi, 2010/10/02
- [PATCH 03/09] replace EPunctMode with SPDPunctuation,
William Hubbs <=
- [PATCH 03/09] replace EPunctMode with SPDPunctuation, Andrei Kholodnyi, 2010/10/03
- question about speech-dispatcher and speakup in maverick, mike cutie and maia, 2010/10/03
- [orca-list] question about speech-dispatcher and speakup in maverick, Bill Cox, 2010/10/03
- [orca-list] question about speech-dispatcher and speakup in maverick, Willem van der Walt, 2010/10/04
- [PATCH 03/09] replace EPunctMode with SPDPunctuation, William Hubbs, 2010/10/03
- [PATCH 03/09] replace EPunctMode with SPDPunctuation, Andrei Kholodnyi, 2010/10/04
[PATCH 02/09] replace ibmtts_voice_enum_to_str with spd_voice2str, William Hubbs, 2010/10/02
[PATCH 01/09] remove flite_set_voice, William Hubbs, 2010/10/01