[PATCH 2/2] move src/audio to src/modules/audio

[Hynek Hanke]

On 18.9.2010 18:17, Andrei Kholodnyi wrote:
> I'd prefer to wait a little bit until Chris and Brailcom people could
> comment on that.
>
>    

I think the correct design is that the audio subsystem
is not part of the modules, but lives separate from the
modules, and the two parts interact.

The audio subsystem needs data from the modules,
the modules need callbacks from the audio subsystem.
I can also imagine the audio system not even being
part of Speech Dispatcher. Currently, this is too much
tied together, both in design and code.

In TTS API, synthesizers/TTS systems have the option
of sending data directly to the audio destination (audio
subsystem or client), as soon as it is available, as much
as is available. There is no reason why the module should
be involved in it as an intermediate. The module only
controls ACCEPT/PLAY/STOP in the audio subsystem
and receives events from it.

This is why we didn't think of moving src/audio inside
of src/modules.

Currently however, the audio subsystem is only used
from the modules, and is used directly, so I do not
object to the change if people think it is more clear
with regards to the current state of things.

The split that makes sense, I think, in the current state,
is between the libraries that are needed or helpful in
creating a module, and the modules themselves.

So another structure that makes sense would be I think:

     src/modules/common (module_utils.c etc.)
     src/modules/common/audio (spd_audio.c etc.)
     src/modules/festival
     src/modules/espeak
     etc.

That would make it very clear where to find relevant things
if you are developing speechd modules out of tree (which is
something we will want to support, in short term).

This is a proposal of course :) Please let me know what do you think.

Best regards,
Hynek Hanke