[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/2] move src/audio to src/modules/audio
From: |
William Hubbs |
Subject: |
[PATCH 2/2] move src/audio to src/modules/audio |
Date: |
Sat, 18 Sep 2010 09:22:32 -0500 |
Hi again Andrei,
I want to add more comments to this, that is why I'm replying to my own
message.
On Fri, Sep 17, 2010 at 03:30:52PM -0500, William Hubbs wrote:
> On Fri, Sep 17, 2010 at 09:34:34PM +0200, Andrei Kholodnyi wrote:
> > Personally I dislike having source code and a subdir in one place.
> > Module consists of 3 parts, communication part, synth part and an audio
> > part.
> > Probably it would be better to have modules/audio, modules/synth,
> > modules/main.
>
> Maybe so, and this is the first step to that. It moves the src/audio
> directory to src/modules/audio since the audio code is only used by the
> modules.
The more I think about this, I'm not sure that splitting up the modules
like this is good since most of the modules just consist of one file
each.
I think a better split might be something like:
src/modules/common, src/modules/audio, src/modules/espeak,
src/modules/festival, src/modules/ivona, etc...
> It sounds to me like we are suggesting the same thing.
It still does. :-) This patch would begin that process by moving the
audio directory under the modules directory. :-)
William
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL:
<http://lists.freebsoft.org/pipermail/speechd/attachments/20100918/25cc37f5/attachment-0001.pgp>
- [PATCH 1/2] remove audio include path from tests Makefile, William Hubbs, 2010/09/17
- [PATCH 1/2] remove audio include path from tests Makefile, William Hubbs, 2010/09/17
- [PATCH 2/2] move src/audio to src/modules/audio, William Hubbs, 2010/09/17
- [PATCH 2/2] move src/audio to src/modules/audio,
William Hubbs <=
- [PATCH 2/2] move src/audio to src/modules/audio, Andrei Kholodnyi, 2010/09/18
- [PATCH 2/2] move src/audio to src/modules/audio, William Hubbs, 2010/09/18
- [PATCH 2/2] move src/audio to src/modules/audio, Andrei Kholodnyi, 2010/09/18
- [PATCH 2/2] move src/audio to src/modules/audio, Christopher Brannon, 2010/09/18
- [PATCH 2/2] move src/audio to src/modules/audio, William Hubbs, 2010/09/18
- [PATCH 2/2] move src/audio to src/modules/audio, Andrei Kholodnyi, 2010/09/18
- [PATCH 2/2] move src/audio to src/modules/audio, William Hubbs, 2010/09/18
- [PATCH 2/2] move src/audio to src/modules/audio, Hynek Hanke, 2010/09/20
- [PATCH 2/2] move src/audio to src/modules/audio, Bohdan R . Rau, 2010/09/20
- [PATCH 2/2] move src/audio to src/modules/audio, Andrei Kholodnyi, 2010/09/20