Re: [rdiff-backup-users] "--compare-hash-at-time" bug?

[Andrew Ferguson]

On Mar 4, 2009, at 11:39 AM, Serge Zub wrote:
> Hi,
>
> The version 1.3.1 still has the problem.
> I've looked into the source and it seems I've found the cause!
>
> File "hash.py":
>
> def compute_sha1(rp, compressed = 0):
>     """Return the hex sha1 hash of given rpath"""
>     assert rp.conn is Globals.local_connection # inefficient not to  
> do locally
>     digest = compute_sha1_fp(rp.open("r", compressed))
>     rp.set_sha1(digest)
>     return digest
>
> "r"  -- file is opened in text mode.
> I suppose that it must be "rb".


Hmm, good thinking.

I've prepared a test-build here with that change:
http://download.savannah.gnu.org/releases-noredirect/rdiff-backup/testing/rdiff-backup-1.3.3pre1.zip

Can you try it and confirm that it fixes the problem?


thanks,
Andrew